Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(x/authz): autocli tx support #17970

Merged
merged 19 commits into from
Oct 8, 2023
Merged

feat(x/authz): autocli tx support #17970

merged 19 commits into from
Oct 8, 2023

Conversation

atheeshp
Copy link
Contributor

@atheeshp atheeshp commented Oct 5, 2023 •
edited
Loading

Description

Closes: #17969

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@atheeshp atheeshp marked this pull request as ready for review October 5, 2023 08:07
@atheeshp atheeshp requested a review from a team as a code owner October 5, 2023 08:07
@atheeshp atheeshp added the S:blocked Status: Blocked label Oct 5, 2023
julienrbrt
julienrbrt reviewed Oct 5, 2023
View reviewed changes
x/authz/module/autocli.go Outdated Show resolved Hide resolved
x/authz/module/autocli.go Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

@atheeshp your pull request is missing a changelog!

Base automatically changed from julien/autocli-from to main October 5, 2023 11:06
@atheeshp atheeshp removed the S:blocked Status: Blocked label Oct 6, 2023
odeke-em
odeke-em reviewed Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@odeke-em odeke-em left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @atheeshp, just a round of reviews.

client/tx/factory.go Outdated Show resolved Hide resolved
client/tx/tx.go Outdated Show resolved Hide resolved
x/authz/module/autocli.go Outdated Show resolved Hide resolved
julienrbrt
julienrbrt approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK!

x/authz/module/autocli.go Outdated Show resolved Hide resolved
@atheeshp atheeshp disabled auto-merge October 6, 2023 13:09
@atheeshp atheeshp disabled auto-merge October 6, 2023 18:38
@julienrbrt
Copy link
Member

It seems like there is a test depending on the deleted command (https://github.com/cosmos/cosmos-sdk/actions/runs/6432070146/job/17468174370?pr=17970).

The tests do not test anything fancy (https://github.com/cosmos/cosmos-sdk/blob/main/tests/e2e/authz/tx.go#L188-L336), so we should ensure the message server test in x/authz tests the same thing (if not add the missing test cases) and remove that tests. (ref #16757)

@atheeshp atheeshp added this pull request to the merge queue Oct 8, 2023
Merged via the queue into main with commit 83622c8 Oct 8, 2023
50 checks passed
@atheeshp atheeshp deleted the ap/authz-tx-autocli branch October 8, 2023 11:36
@julienrbrt julienrbrt mentioned this pull request Oct 10, 2023
Merged
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odeke-em odeke-em odeke-em left review comments

@tac0turtle tac0turtle tac0turtle approved these changes

@julienrbrt julienrbrt julienrbrt approved these changes

Assignees

@tac0turtle tac0turtle

@julienrbrt julienrbrt

Labels
C:CLI C:x/authz
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AutoCLI Tx Options for x/authz
4 participants
@atheeshp @julienrbrt @odeke-em @tac0turtle